Adding dataVersionFilter support to MDS to enable version decoupling #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamakrishnaChilaka
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
BionIT
approved these changes
Jul 10, 2024
ZilongX
reviewed
Jul 11, 2024
BionIT
approved these changes
Jul 11, 2024
ZilongX
approved these changes
Jul 11, 2024
SuZhou-Joe
previously approved these changes
Jul 11, 2024
Signed-off-by: Ramakrishna Chilaka <[email protected]>
Signed-off-by: Ramakrishna Chilaka <[email protected]>
RamakrishnaChilaka
force-pushed
the
main
branch
2 times, most recently
from
c7b535c to
43c78e4
Compare
BionIT
approved these changes
Jul 11, 2024
SuZhou-Joe
approved these changes
Jul 11, 2024
|
A little bit weird why macos always failed. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1080-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50c2275589fcfe9427d0db88a9a91eebb3325e12
# Push it to GitHub
git push --set-upstream origin backport/backport-1080-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.xThen, create a pull request where the |
RamakrishnaChilaka
added a commit
to RamakrishnaChilaka/index-management-dashboards-plugin
that referenced
this pull request
Jul 11, 2024
…pensearch-project#1080) * Adding dataVersionFilter support to MDS to enable version decoupling Signed-off-by: Ramakrishna Chilaka <[email protected]> * added check for checking available plugins on a datasource Signed-off-by: Ramakrishna Chilaka <[email protected]> --------- Signed-off-by: Ramakrishna Chilaka <[email protected]> (cherry picked from commit 50c2275)
This was referenced Jul 11, 2024
CaptainDredge
pushed a commit
to CaptainDredge/index-management-dashboards-plugin
that referenced
this pull request
Jul 12, 2024
…pensearch-project#1080) * Adding dataVersionFilter support to MDS to enable version decoupling Signed-off-by: Ramakrishna Chilaka <[email protected]> * added check for checking available plugins on a datasource Signed-off-by: Ramakrishna Chilaka <[email protected]> --------- Signed-off-by: Ramakrishna Chilaka <[email protected]>
RamakrishnaChilaka
added a commit
to RamakrishnaChilaka/index-management-dashboards-plugin
that referenced
this pull request
Jul 16, 2024
…pensearch-project#1080) * Adding dataVersionFilter support to MDS to enable version decoupling Signed-off-by: Ramakrishna Chilaka <[email protected]> * added check for checking available plugins on a datasource Signed-off-by: Ramakrishna Chilaka <[email protected]> --------- Signed-off-by: Ramakrishna Chilaka <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 16, 2024
…1080) (#1083) * Adding dataVersionFilter support to MDS to enable version decoupling * added check for checking available plugins on a datasource --------- Signed-off-by: Ramakrishna Chilaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds changes for version decoupling by passing filter function which utilises manifest file to filter data sources.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.